________________________________________
From: [email protected] <[email protected]> on
behalf of Alin Serdean <[email protected]>
Sent: Thursday, July 13, 2017 9:40 PM
To: [email protected]
Subject: [ovs-dev] [PATCH 07/40] datapath-windows: Add asserts to Stt
Unfortunately the WDK 10 static code analysis can't see this one clearly.
Add an ASSERT to silence the warning.
Signed-off-by: Alin Gabriel Serdean <[email protected]>
---
datapath-windows/ovsext/Stt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/datapath-windows/ovsext/Stt.c b/datapath-windows/ovsext/Stt.c
index 7726470..293eb74 100644
--- a/datapath-windows/ovsext/Stt.c
+++ b/datapath-windows/ovsext/Stt.c
@@ -694,6 +694,7 @@ OvsSttReassemble(POVS_SWITCH_CONTEXT switchContext,
entry->timeout = currentTime + STT_ENTRY_TIMEOUT;
if (segOffset == 0) {
+ ASSERT(sttHdr);
entry->sttHdr = *sttHdr;
}
@@ -721,6 +722,7 @@ OvsSttReassemble(POVS_SWITCH_CONTEXT switchContext,
}
if (segOffset == 0) {
+ ASSERT(sttHdr);
pktFragEntry->sttHdr = *sttHdr;
}
if (ipHdr->ecn == IP_ECN_CE) {
--
2.10.2.windows.1
_______________________________________________
Acked-by: Shashank Ram <[email protected]>=
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev