On 26 Jul 2026, at 17:33, Eli Britstein wrote:
> A netdev_dpdk object can be an ethernet dpdk or a vhost-user port.
> The dev_type field was used to determine that.
> Instead, introduce netdev_dpdk_is_vhost() and remove the dev_type field.
The AI reported that you forgot to update the commit message.
//Eelco
commit dc4ed92c0e1b ("netdev-dpdk: Remove dev_type field.")
Author: Eli Britstein <[email protected]>
This patch removes the enum dpdk_dev_type and the dev->type field
from struct netdev_dpdk, replacing all type checks with a new
static helper that distinguishes ethernet from vhost devices by
comparing the destruct function pointer.
The commit message body says:
> Instead, introduce netdev_dpdk_is_vhost() and remove the
> dev_type field.
The function actually introduced is netdev_dpdk_is_eth() in
lib/netdev-dpdk.c, which has the opposite polarity -- it returns
true for ethernet devices, not vhost devices. All call sites in
the diff use netdev_dpdk_is_eth(). Should the commit message say
netdev_dpdk_is_eth() instead of netdev_dpdk_is_vhost()?
[...]
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
