Re: [ovs-dev] [dpdk-latest v6 05/10] netdev-dpdk: Change access from dev->common.xxx to common->xxx.

[Eelco Chaudron via dev]

On 26 Jul 2026, at 17:33, Eli Britstein wrote:

> Change function signatures to take struct netdev_dpdk_common instead of
> struct netdev_dpdk, and update internal accesses from dev->common.xxx to
> common->xxx.  This makes these functions reusable by netdev-doca which
> also operates on netdev_dpdk_common.
>
> Signed-off-by: Eli Britstein <el...@nvidia.com>

One more AI review comment which looks valid.

//Eelco

commit dd31f8a84df3ee922de7e8ed9d2b7eda42a13ca2 ("netdev-dpdk: Change
access from dev->common.xxx to common->xxx.")
Author: Eli Britstein <el...@nvidia.com>

This patch refactors netdev-dpdk functions to take struct
netdev_dpdk_common instead of struct netdev_dpdk, converting internal
accesses from dev->common.xxx to common->xxx for reuse by netdev-doca.

> struct netdev_dpdk_common *common = &dev->common;
> [...]
> common->flags |= on;
> common->flags &= ~off;
> [...]
> if ((dev->common.flags ^ *old_flagsp) & NETDEV_UP) {
> [...]
> common->flags & NETDEV_UP

In netdev_dpdk_update_flags__, one reference to dev->common.flags
was not converted to common->flags, while every other access in the
same function uses the local common pointer. Since common is just
&dev->common this has no runtime effect, but it leaves the
refactoring incomplete -- the stated goal is to make these function
bodies independent of struct netdev_dpdk. Was this line overlooked?

[...]

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev