>> yes, this is an artificial dependency. Another way I'm thinking is for
>> ovs-vswitchd
>>  to hold the geneve.ko dependency instead of openvswitch.ko, when user 
>> creates
>> a geneve device. Is there a way to do that through rtnetlink or at
>> dpif_netlink_rtnl_create()?
>
> It should be vport-netdev doing the magic. It creates the linkage with
> netdev_master_upper_dev_link(), but apparently that is not enough to
> bump the kernel module refcnt and thus prevent unloading. Maybe you can
> dig into why that is. AFAICS, it should be linking openvswitch.ko and
> and geneve.ko with that call.

Sure, will take a look.
>
>> >
>> > This patch also only address GENEVE, what about VXLAN and GRE?
>> >
>>
>> Yes, we will need to address vxlan and gre later.
>
> vport-netdev.c should be the one that holds onto the underlying device.
> As such, this should be common and take care of all three.

Agree, that's a better place to take care of all tunnels.

William
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to