On Mon, Dec 11, 2017 at 08:23:44PM +0000, Alin Serdean wrote: > LGTM. Just two nits.
> > + /* Terminal error state that indicates that nothing useful can be done. > > + * The most likely reason is that the database server doesn't actually > > have > [Alin Serdean] doesn't have, maybe? OK, thanks. > > @@ -1118,7 +1153,7 @@ ovsdb_idl_condition_clone(struct > > ovsdb_idl_condition *dst, > > * arranges to send the new condition to the database server. > > * > > * Return the next conditional update sequence number. When this > > - * value and ovsdb_idl_get_condition_seqno() matchs, the 'idl' > > + * value and ovsdb_idl_get_condition_seqno() matches, the 'idl' > > * contains rows that match the 'condition'. > > */ > > unsigned int > > -- > s/. *\//. *\// I don't understand that suggestion. Maybe you were suggesting that */ should be on the same line as the last word; if so, OK, sure. > Acked-by: Alin Gabriel Serdean <[email protected]> Thank you for the review. I'll apply patches 1-3 soon. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
