> -----Original Message----- > From: Ben Pfaff [mailto:[email protected]] > Sent: Tuesday, December 12, 2017 12:40 AM > To: Alin Serdean <[email protected]> > Cc: [email protected] > Subject: Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments. > > On Mon, Dec 11, 2017 at 10:34:06PM +0000, Alin Serdean wrote: > > > > > > > -----Original Message----- > > > From: Ben Pfaff [mailto:[email protected]] > > > Sent: Tuesday, December 12, 2017 12:30 AM > > > To: Alin Serdean <[email protected]> > > > Cc: [email protected] > > > Subject: Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments. > > > > > > On Mon, Dec 11, 2017 at 08:23:44PM +0000, Alin Serdean wrote: > > > > LGTM. Just two nits. > > > > > > > > + /* Terminal error state that indicates that nothing useful can be > done. > > > > > + * The most likely reason is that the database server > > > > > + doesn't actually have > > > > [Alin Serdean] doesn't have, maybe? > > > > > > OK, thanks. > > > > > > > > @@ -1118,7 +1153,7 @@ ovsdb_idl_condition_clone(struct > > > > > ovsdb_idl_condition *dst, > > > > > * arranges to send the new condition to the database server. > > > > > * > > > > > * Return the next conditional update sequence number. When > > > > > this > > > > > - * value and ovsdb_idl_get_condition_seqno() matchs, the 'idl' > > > > > + * value and ovsdb_idl_get_condition_seqno() matches, the 'idl' > > > > > * contains rows that match the 'condition'. > > > > > */ > > > > > unsigned int > > > > > -- > > > > s/. *\//. *\// > > > > > > I don't understand that suggestion. Maybe you were suggesting that > > > */ should be on the same line as the last word; if so, OK, sure. > > [Alin Serdean] I think in some places there is `. */` vs `. */` , but > > maybe my > email client messed up the formatting. > > Oh. Got it. I'll try to be more consistent. > > (I was a little confused by regex syntax. '.' and '*' are special > characters.) [Alin Serdean] My bad, I forgot to escape them 😊.
_______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
