On Tue, Jan 23, 2018 at 09:46:26AM -0600, Mark Michelson wrote: > On 01/19/2018 11:08 PM, amgin...@gmail.com wrote: > >From: aginwala <aginw...@ebay.com> > > > >e.g. when running ovn-nbctl show ls, it's good to have total ports that are > >attached to the switch. > > > >Signed-off-by: Aliasgar Ginwala <aginw...@ebay.com> > >--- > > ovn/utilities/ovn-nbctl.c | 1 + > > tests/ovn-nbctl.at | 10 ++++++---- > > 2 files changed, 7 insertions(+), 4 deletions(-) > > > >diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c > >index c9aa2fe..0f1e952 100644 > >--- a/ovn/utilities/ovn-nbctl.c > >+++ b/ovn/utilities/ovn-nbctl.c > >@@ -682,6 +682,7 @@ print_ls(const struct nbrec_logical_switch *ls, struct > >ds *s) > > ds_put_format(s, " router-port: %s\n", router_port); > > } > > } > >+ ds_put_format(s, "total_ports_on_switch: %u\n", ls->n_ports); > > } > > I think the wording here is a bit strange when compared to other output from > `ovn-nbctl show`. I think something like "total ports" instead of > "total_ports_on_switch" would be more consistent. > > I also think that if you're adding this for logical switches, you should do > the same for logical routers.
In addition, I don't understand why this is valuable information to show. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
