> On 01/19/2018 11:08 PM, [email protected] wrote: > >From: aginwala <[email protected]> > > > >e.g. when running ovn-nbctl show ls, it's good to have total ports that are > >attached to the switch. > > > >Signed-off-by: Aliasgar Ginwala <[email protected]> > >--- > > ovn/utilities/ovn-nbctl.c | 1 + > > tests/ovn-nbctl.at | 10 ++++++---- > > 2 files changed, 7 insertions(+), 4 deletions(-) > > > >diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c > >index c9aa2fe..0f1e952 100644 > >--- a/ovn/utilities/ovn-nbctl.c > >+++ b/ovn/utilities/ovn-nbctl.c > >@@ -682,6 +682,7 @@ print_ls(const struct nbrec_logical_switch *ls, struct ds *s) > > ds_put_format(s, " router-port: %s\n", router_port); > > } > > } > >+ ds_put_format(s, "total_ports_on_switch: %u\n", ls->n_ports); > > } > > I think the wording here is a bit strange when compared to other output from > `ovn-nbctl show`. I think something like "total ports" instead of > "total_ports_on_switch" would be more consistent. > > I also think that if you're adding this for logical switches, you should do > the same for logical routers.
>>In addition, I don't understand why this is valuable information to show. I was keeping it total_ports but that was confusing as it seems all ports. Hence I chose total_ports_per_switch. I can add the same for routers too.We added this because when we have many ports on a switch it's easy to say from count that we have n ports on the switch. During scale test we found this information useful because by looking at the total_ports_on_switch we can also assure that the count on the chassis matches the count on the controller as a quick scan too. Let me know further. On Tue, Jan 23, 2018 at 9:27 AM, Ben Pfaff <[email protected]> wrote: > On Tue, Jan 23, 2018 at 09:46:26AM -0600, Mark Michelson wrote: > > On 01/19/2018 11:08 PM, [email protected] wrote: > > >From: aginwala <[email protected]> > > > > > >e.g. when running ovn-nbctl show ls, it's good to have total ports that > are > > >attached to the switch. > > > > > >Signed-off-by: Aliasgar Ginwala <[email protected]> > > >--- > > > ovn/utilities/ovn-nbctl.c | 1 + > > > tests/ovn-nbctl.at | 10 ++++++---- > > > 2 files changed, 7 insertions(+), 4 deletions(-) > > > > > >diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c > > >index c9aa2fe..0f1e952 100644 > > >--- a/ovn/utilities/ovn-nbctl.c > > >+++ b/ovn/utilities/ovn-nbctl.c > > >@@ -682,6 +682,7 @@ print_ls(const struct nbrec_logical_switch *ls, > struct ds *s) > > > ds_put_format(s, " router-port: %s\n", > router_port); > > > } > > > } > > >+ ds_put_format(s, "total_ports_on_switch: %u\n", ls->n_ports); > > > } > > > > I think the wording here is a bit strange when compared to other output > from > > `ovn-nbctl show`. I think something like "total ports" instead of > > "total_ports_on_switch" would be more consistent. > > > > I also think that if you're adding this for logical switches, you should > do > > the same for logical routers. > > In addition, I don't understand why this is valuable information to > show. > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
