> On Jan 23, 2018, at 12:01 PM, Gregory Rose <[email protected]> wrote: > > On 1/23/2018 12:00 PM, Justin Pettit wrote: >> >>> On Jan 5, 2018, at 11:30 AM, Greg Rose <[email protected]> wrote: >>> >>> +#ifdef frag_percpu_counter_batch >>> ... >>> +#else /* frag_percpu_counter_batch */ >> This is kind of a nit, but I would have thought this "#else" comment would >> be "!frag_percpu_counter_batch", since that's the case when it's not >> defined. However, I'm not sure how it's handled usually in the kernel. >> Looking through our compat code, I see examples of it being done both ways, >> though. Thoughts? >> >> --Justin >> >> > It's a valid nit. > > I can send V2 or you can fix it on push. Which do you prefer?
I went ahead and made the change. I pushed it to master and branch-2.9. --Justin _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
