> On Jan 23, 2018, at 12:34 PM, Ben Pfaff <[email protected]> wrote: > > On Tue, Jan 23, 2018 at 12:00:20PM -0800, Justin Pettit wrote: >> >> >>> On Jan 5, 2018, at 11:30 AM, Greg Rose <[email protected]> wrote: >>> >>> +#ifdef frag_percpu_counter_batch >>> ... >>> +#else /* frag_percpu_counter_batch */ >> >> This is kind of a nit, but I would have thought this "#else" comment >> would be "!frag_percpu_counter_batch", since that's the case when it's >> not defined. However, I'm not sure how it's handled usually in the >> kernel. Looking through our compat code, I see examples of it being >> done both ways, though. Thoughts? > > This is one of those weird places where style differs. GNU coding > standards would mandate "!frag_percpu_counter_batch" here, and that's > what I prefer myself, but I've seen the opposite convention in (if I > recall correctly) some BSD code.
Interesting. I decided to add the "!", since I think it makes it clearer. --Justin _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
