On Wed, Jan 24, 2018 at 09:41:11AM -0800, Ben Pfaff wrote: > From: Huanle Han <[email protected]> > > Some functions, such as xlate_normal_mcast_send_mrouters, test xbundle > pointers equality to avoid sending packet back to in bundle. However, > xbundle pointers port from different xcfgp for same port are inequal. > This may lead to the packet loopback. > > This commit stores xcfgp on ctx at first and always uses the same xcfgp > during one packet process period. > > Signed-off-by: Huanle Han <[email protected]>
This seems like an improvement and a fix for an important bug. Thank you for submitting it. I am a little surprised that xlate_get_cfg() exists. It implies that sometimes 'ctx' might be null or that 'ctx->xcfg' might be null. Do you know a code path where this could be true? I do not see one, off-hand. Thanks, Ben. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
