On Wed, Jan 24, 2018 at 09:41:12AM -0800, Ben Pfaff wrote: > From: Huanle Han <[email protected]> > > Signed-off-by: Huanle Han <[email protected]> > --- > ofproto/ofproto-dpif-xlate.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c > index 9d6ca94afc82..23938c8c8cf3 100644 > --- a/ofproto/ofproto-dpif-xlate.c > +++ b/ofproto/ofproto-dpif-xlate.c > @@ -1931,6 +1931,10 @@ mirror_packet(struct xlate_ctx *ctx, struct xbundle > *xbundle, > return; > } > > + if (ctx->xin->flow.recirc_id != 0) { > + return; > + } > +
Can you help me understand what cases this addresses? The frozen_state that comes along with a recirculation should keep track of what mirrors have already been output, which should prevent duplicate mirroring on recirculation. If it doesn't work in every case, then probably we should address that instead of just disabling mirroring on recirculation. Thanks, Ben. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
