On 1/31/2018 5:53 AM, Yi Yang wrote:
v1->v2
  - Fix compilation error in linux-3.10.107

This patch series is to backport NSH support patches in Linux net-next tree
to OVS in order that it can support NSH in kernel compat mode.

Yi Yang (5):
   datapath: ether: add NSH ethertype
   datapath: vxlan: factor out VXLAN-GPE next protocol
   datapath: net: add NSH header structures and helpers
   datapath: nsh: add GSO support
   datapath: enable NSH support

  NEWS                                              |   1 +
  acinclude.m4                                      |   1 +
  datapath/Modules.mk                               |   4 +-
  datapath/actions.c                                | 116 ++++++++
  datapath/datapath.c                               |   4 +
  datapath/flow.c                                   |  51 ++++
  datapath/flow.h                                   |   7 +
  datapath/flow_netlink.c                           | 343 +++++++++++++++++++++-
  datapath/flow_netlink.h                           |   5 +
  datapath/linux/Modules.mk                         |   2 +
  datapath/linux/compat/include/linux/if_ether.h    |   4 +
  datapath/linux/compat/include/linux/netdevice.h   |  14 +
  datapath/linux/compat/include/linux/openvswitch.h |   6 +-
  datapath/linux/compat/include/net/nsh.h           | 313 ++++++++++++++++++++
  datapath/linux/compat/include/net/tun_proto.h     |  49 ++++
  datapath/linux/compat/include/net/vxlan.h         |   6 -
  datapath/linux/compat/vxlan.c                     |  32 +-
  datapath/nsh.c                                    | 142 +++++++++
  18 files changed, 1063 insertions(+), 37 deletions(-)
  create mode 100644 datapath/linux/compat/include/net/nsh.h
  create mode 100644 datapath/linux/compat/include/net/tun_proto.h
  create mode 100644 datapath/nsh.c


Yi,

I have finished review of the patches and they look fine to me.  As per our offline discussions it doesn't seem as if there is a test framework available for me right now to be able to test the patches but I did make sure there are no regressions in our current test and compile.  The patches passed
the travis check here:

https://travis-ci.org/gvrose8192/ovs-experimental/builds/336662468

I am collaborating with a co-worker here at VMware to document and create an NSH test bed but that won't
be done for a while.

I'll go ahead and provide my review sign off but for obvious reasons I can't apply a tested by sign off. I think the patches are pretty well vetted both upstream and here and I think they're fine to apply so that we can get started testing.  I don't think there will be any negative effect on current features or code stability - no "make check" and "make check-kmod" tests show any regressions  It will be up to
the maintainers whether this is sufficient to apply your patches.

For the series...

Reviewed-by: Greg Rose <gvrose8...@gmail.com>

Thanks,

- Greg

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to