Hi, On 25 July 2018 at 23:17, Justin Pettit <[email protected]> wrote:
> > > On Jul 25, 2018, at 2:11 PM, Ben Pfaff <[email protected]> wrote: > > > > On Wed, Jul 25, 2018 at 02:01:32PM -0700, Justin Pettit wrote: > >> Commit ab15e70eb587 ("dpctl: Expand the flow dump type filter") had a > >> number of issues with style, build breakage, and failing unit tests. > >> The patch is being reverted so that they can addressed. > >> > >> This reverts commit ab15e70eb5878b46f8f84da940ffc915b6d74cad. > >> > >> CC: Gavi Teitz <[email protected]> > >> CC: Simon Horman <[email protected]> > >> CC: Roi Dayan <[email protected]> > >> CC: Aaron Conole <[email protected]> > >> Signed-off-by: Justin Pettit <[email protected]> > > > > For the series: > > Acked-by: Ben Pfaff <[email protected]> > > since it breaks unit tests and it isn't obvious how to fix them. > > Thanks. > > > But I suggest giving Simon and the others a chance to respond. > > Okay. > > > By the way, when you have CC: in a commit message, you're supposed to > > actually CC those people in the email. "git send-email" does that > > automatically for me but it looks like it didn't pick them up for you. > > Hmm. My "git send-email" says that they were all cc'd in the output of > the command, but my mail client only shows Simon. I don't know where, or > if, there's a problem, but it thinks it worked. Sorry about this. I agree a revert was the correct course of action. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
