> On Jul 26, 2018, at 7:29 AM, Gavi Teitz <[email protected]> wrote:
>
> From: Justin Pettit, sent: Thursday, July 26, 2018 12:02 AM:
>> Commit ab15e70eb587 ("dpctl: Expand the flow dump type filter") had a number
>> of issues with style, build breakage, and failing unit tests.
>> The patch is being reverted so that they can addressed.
>
> I acknowledge the build breakage issue, could you elaborate regarding the
> style issues?
The main style issue was that lines shouldn't be over 79 characters longs.
> As for the failing unit tests, this commit provides the means to fix unit
> tests that lost their relevance due to the changes introduced in commit
> d63ca5329ff9 ("dpctl: Properly reflect a rule's offloaded to HW state"). Are
> there other unit tests that are broken due to this commit?
I saw about a dozen unit tests failing when I ran "make check".
Thanks,
--Justin
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
