On Thu, Jul 12, 2018 at 12:59:31PM +0530, Sriharsha Basavapatna via dev wrote: > This is the first patch in the patch-set to support dynamic rebalancing > of offloaded flows. > > The patch detects OOR condition on a netdev port when ENOSPC error is > returned by TC-Flower while adding a flow rule. A new structure is added > to the netdev called "netdev_hw_info", to store OOR related information > required to perform dynamic offload-rebalancing. > > Signed-off-by: Sriharsha Basavapatna <[email protected]> > Co-authored-by: Venkat Duvvuru <[email protected]> > Signed-off-by: Venkat Duvvuru <[email protected]> > Reviewed-by: Sathya Perla <[email protected]>
Thanks for the patches and for the recent information on their performance benefits and costs. Please incorporate that information into the next version of the series. I have some comments. Some of the style differs from what we usually expect. Here, I see some 8-space indentation (or maybe it's a tab? not sure) in parse_flow_put(); please use 4-space indentation. In flow_get_tunnel_netdev, there's a return of the form "return (x);"; please omit the parentheses. I don't think that the tunnel_netdev variable is needed in flow_get_tunnel_netdev(). This patch doesn't provide a function to read the oor or netdev_hw_info for a netdev. The netdev struct is supposed to be opaque to clients; please provide an interface rather than having clients directly access the member. Please don't add a blank line above netdev_ports_flow_init(). Thanks, Ben. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
