On 09/26/2018 11:05 PM, Ophir Munk wrote: > Hi Kevin, > I have reviews to be addressed in v5 which may change v4. > Therefore I suggest sending v5 (hopefully) as the final version for this > PATCH. > Please let me know if you still want me to resend v4 to the ML.
No need - makes sense to just send v5 in that case. thanks, Kevin. > Regards, > Ophir > >> -----Original Message----- >> From: Kevin Traynor [mailto:[email protected]] >> Sent: Wednesday, September 26, 2018 12:47 PM >> To: Ophir Munk <[email protected]>; [email protected] >> Cc: Asaf Penso <[email protected]>; Sugesh Chandran >> <[email protected]>; Ian Stokes <[email protected]>; Ben >> Pfaff <[email protected]>; Shahaf Shuler <[email protected]>; Thomas >> Monjalon <[email protected]>; Olga Shern <[email protected]> >> Subject: Re: [dpdk-howl PATCH v4] netdev-dpdk: Upgrade to dpdk v18.08 >> >> On 09/21/2018 11:12 AM, Ophir Munk wrote: >>> 1. Enable compilation and linkage with dpdk 18.08.0 The following dpdk >>> commits which were introduced after dpdk 17.11.x require OVS updates >>> to accommodate to the dpdk changes. >>> - ce17edde ("ethdev: introduce Rx queue offloads API") >>> - ab3ce1e0 ("ethdev: remove old offload API") >>> - c06ddf96 ("meter: add configuration profile") >>> - e58638c3 ("ethdev: fix TPID handling in flow API") >>> - cd8c7c7c ("ethdev: replace bus specific struct with generic dev") >>> - ac8d22de ("ethdev: flatten RSS configuration in flow API") >>> >>> 2. Limit configured rss hash functions to only those supported by the >>> eth device. >>> >>> 3. Set default RSS key in struct action_rss_data, required by OVS >>> commit >>> - e8a2b5bf ("netdev-dpdk: implement flow offload with rte flow") when >>> configured with "other_config:hw-offload=true" >>> >>> 4. Update references to DPDK version 18.08 in Documentation >>> >>> 5. Update DPDK version 18.08 in travis' linux-build script >>> >>> Signed-off-by: Ophir Munk <[email protected]> >>> --- >>> v1: >>> First version >>> >>> v2: >>> Avoid seg faults cases as described in >>> >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat >>> >> chwork.ozlabs.org%2Fpatch%2F965451%2F&data=02%7C01%7Cophirm >> u%40mel >>> >> lanox.com%7C92464c8120cf4c14ebaa08d62394f775%7Ca652971c7d2e4d9b >> a6a4d14 >>> >> 9256f461b%7C0%7C0%7C636735520041931061&sdata=vhHc3nMU3Gg >> MBDOgqtZWL >>> TEk%2FBnswcZM%2BZhVt6hMK00%3D&reserved=0 >>> by using the patch in: >>> >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit >>> hub.com%2Fkevintraynor%2Fovs-dpdk- >> &data=02%7C01%7Cophirmu%40mellan >>> >> ox.com%7C92464c8120cf4c14ebaa08d62394f775%7Ca652971c7d2e4d9ba6 >> a4d14925 >>> >> 6f461b%7C0%7C0%7C636735520041931061&sdata=KR8HIJBkKqXwUsC >> BeOwWMUi% >>> 2BPgqOKJnu%2FCqZ1Zo3JuM%3D&reserved=0 >>> master/commit/88f46cc5ab338eb4f3ca5db1eacd0effefe4fa0c >>> >>> v3: >>> - rebase on latest dpdk-hwol branch >>> - Updates based on latest reviews to versions v1 & v2 >>> >>> v4: >>> - update commit message >>> - Set default RSS key in struct action_rss_data, required by OVS >>> commit e8a2b5bf ("netdev-dpdk: implement flow offload with rte flow") >>> when configured with "other_config:hw-offload=true" >>> >> >> Hi Ophir, I can't see this v4 in the ML archives or patchwork - I suspect it >> got >> dropped during some ML issues last week. Perhaps you could resend to the >> ML. >> >> Kevin. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
