> > 1. Enable compilation and linkage with dpdk 18.08.0 The following dpdk
> > commits which were introduced after dpdk 17.11.x require OVS updates
> > to accommodate to the dpdk changes.
> > - ce17edde ("ethdev: introduce Rx queue offloads API")
> > - ab3ce1e0 ("ethdev: remove old offload API")
> > - c06ddf96 ("meter: add configuration profile")
> > - e58638c3 ("ethdev: fix TPID handling in flow API")
> > - cd8c7c7c ("ethdev: replace bus specific struct with generic dev")
> > - ac8d22de ("ethdev: flatten RSS configuration in flow API")
> >
> > 2. Limit configured rss hash functions to only those supported by the
> > eth device.
> >
> > 3. Set default RSS key in struct action_rss_data, required by OVS
> > commit
> > - e8a2b5bf ("netdev-dpdk: implement flow offload with rte flow") when
> > configured with "other_config:hw-offload=true"
> > Remark: calling RSS with 0 length (default) key is rejected in DPDK
> > 18.08 and will be enabled in DPDK 18.11. It has no effect when running
> > in a "hw- offload=false" configuration.
> >
> > 4. Update references to DPDK version 18.08 in Documentation and in
> > travis linux-build script
> >
> > 5. There are currently warnings on DPDK deprecated functions calls:
> > - rte_eth_dev_attach
> > - rte_eth_dev_detach
> > - rte_eth_devargs_parse
> > The deprecated functions calls replacements will be added to DPDK 18.11.
> >
> 
> Thanks for this Ophir,
> 
> I believe with the exception of 1 comment from Ilya regarding a comment,
> all queries have been addressed in the v6.
> 
> I've completed a validation of all major features and everything seems ok.
> 
> I don't see any acks on the patchset to date. Is there any outstanding
> issue blocking people from signing off?
> 
> I'm aware that DPDK 18.11 RC2 has been released today. With that in mind I
> propose we merge these patches to dpdk_latest and the dpdk_hwol branches
> in the OVS repo.
> 
> That will allow us to begin testing with 18.11 RC2 and start work on any
> patches required OVS DPDK.
> 
> Any objections?
> 
> Thanks
> Ian

There's been no other feedback on this series so I'm assuming its ok to go. 
Thanks to all for the reviews to date.

I've rebased this to the head of master and pushed it to dpdk-hwol and 
dpdk-latest. 

Thanks Ian

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to