Bleep bloop. Greetings Eli Britstein, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate bracing around statement
#49 FILE: lib/odp-util.c:7113:
if (size == 0)
ERROR: Inappropriate bracing around statement
#52 FILE: lib/odp-util.c:7116:
if (memcmp(pkey0, pkey1, size) == 0)
ERROR: Inappropriate bracing around statement
#54 FILE: lib/odp-util.c:7118:
else
WARNING: Line is 90 characters long (recommended limit is 79)
#77 FILE: lib/odp-util.c:7174:
#define OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_ethernet, name),
sizeof(type)},
WARNING: Line is 86 characters long (recommended limit is 79)
#100 FILE: lib/odp-util.c:7317:
#define OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_ipv4, name),
sizeof(type)},
WARNING: Line is 86 characters long (recommended limit is 79)
#122 FILE: lib/odp-util.c:7378:
#define OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_ipv6, name),
sizeof(type)},
WARNING: Line is 85 characters long (recommended limit is 79)
#144 FILE: lib/odp-util.c:7438:
#define OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_arp, name),
sizeof(type)},
WARNING: Line is 86 characters long (recommended limit is 79)
#165 FILE: lib/odp-util.c:7479:
#define OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_icmp, name),
sizeof(type)},
WARNING: Line is 84 characters long (recommended limit is 79)
#188 FILE: lib/odp-util.c:7532:
#define OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_nd, name),
sizeof(type)},
WARNING: Line is 85 characters long (recommended limit is 79)
#209 FILE: lib/odp-util.c:7751:
#define OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_tcp, name),
sizeof(type)},
Lines checked: 345, Warnings: 7, Errors: 3
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
