On Wed, Jan 23, 2019 at 01:17:21PM +0000, Eli Britstein wrote: > > On 1/23/2019 2:14 AM, Ben Pfaff wrote: > > On Fri, Jan 11, 2019 at 08:28:57AM +0200, Eli Britstein wrote: > >> Hi > >> > >> This patch set avoids unnecessary rewrite actions to fields with the > >> same values as matched on. > >> > >> Patch 1 is a pre-step by defining ovs key structs using macros > >> > >> Patch 2 avoids the unnecessary rewrites and adapts the tests accordingly > > I like the goal of the patch, but it makes openvswitch.h unreadable and > > completely different from Linux upstream. One of the goals of that > > "sed" script is to avoid having it be different from upstream. I think > > unreadable - well, it's a point of view, but i don't think that's alone > is a justified argument not to change > > completely different - that's correct. why don't we just push the same > change to the Linux upstream to keep it the same?
OK, let me know when you get it upstream and I'll look again. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
