On 07.02.2019 19:18, Ian Stokes wrote:
> On 2/7/2019 1:00 PM, Ilya Maximets wrote:
>> This fixes build with NUMA_AWARE_HUGEPAGES enabled and VHOST_NUMA
>> disabled. This should not be a usual case. But it's possible to
>> configure DPDK this way.
>>
>
> Out of interest, with RTE_EAL_NUMA_AWARE_HUGEPAGES defined but not
> RTE_LIBRTE_VHOST_NUMA, does vhost numa still work as expected?
If RTE_LIBRTE_VHOST_NUMA disabled, all the numa related code from
librte_vhost will be compiled out. So, rte_vhost_get_numa_node()
will always return -1. i.e. we will not be able to reallocate
memory pools according to numa node where VM started.
At the same time eal_memory and eal_memalloc modules will work fine
allocating hugepages and memory from the requested numa nodes.
>
> Ian
>> Fixes: 5e925ccc2a6f ("netdev-dpdk: DPDK v17.11 upgrade")
>>
>> Signed-off-by: Ilya Maximets <[email protected]>
>> ---
>> acinclude.m4 | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/acinclude.m4 b/acinclude.m4
>> index c51af246a..e2af4ee16 100644
>> --- a/acinclude.m4
>> +++ b/acinclude.m4
>> @@ -254,7 +254,7 @@ AC_DEFUN([OVS_CHECK_DPDK], [
>> AC_LANG_PROGRAM(
>> [
>> #include <rte_config.h>
>> -#if RTE_LIBRTE_VHOST_NUMA
>> +#if defined(RTE_LIBRTE_VHOST_NUMA) || defined(RTE_EAL_NUMA_AWARE_HUGEPAGES)
>> #error
>> #endif
>> ], [])
>>
>
>
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
