On 4/1/2019 10:21 AM, Yifeng Sun wrote:
As commented, previously flex_array was used because "we can have large
     hash-table without large contiguous kernel memory".

Actually how large can the flow hash table can be? Will this backport
affect currently supported hash table size?
Hi Yifeng,

sorry for the late reply...

The introduction of kvmalloc in the Linux kernel with commit a7c3e901a4 "mm: introduce kv[mz]alloc helpers" helps explain.  kvmalloc_array() will allocate large, contiguous memory areas.

As noted in this patch by Kent Overstreet we should probably use rhashtable instead but that would take
additional work and is for future development.

Thanks,

- Greg


Thanks,
Yifeng

On Wed, Mar 27, 2019 at 9:06 AM 0-day Robot <[email protected]> wrote:
Bleep bloop.  Greetings Gregory Rose, I am a robot and I have tried out your 
patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Author Kent Overstreet <[email protected]> needs to sign off.
WARNING: Unexpected sign-offs from developers who are not authors or co-authors or 
committers: Greg Rose <[email protected]>
Lines checked: 208, Warnings: 1, Errors: 1


Please check this out.  If you feel there has been an error, please email 
[email protected]

Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to