On Tue, Apr 09, 2019 at 06:21:21PM -0700, Han Zhou wrote: > From: Han Zhou <[email protected]> > > raft_command's eid should always be non-null in all 3 cases. Fix the > comment, and also replace if condition with assert. > > Signed-off-by: Han Zhou <[email protected]> > --- > ovsdb/raft.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/ovsdb/raft.c b/ovsdb/raft.c > index abcc9c0..32dcea6 100644 > --- a/ovsdb/raft.c > +++ b/ovsdb/raft.c > @@ -112,7 +112,7 @@ struct raft_command { > /* Case 1 only. */ > uint64_t index; /* Index in log (0 if being relayed). */ > > - /* Cases 2 and 3. */ > + /* Cases 1, 2 and 3. */ > struct uuid eid; /* Entry ID of result. */ > > /* Case 2 only. */
Thanks for the correction. Since there's already a section for "all cases", I'd suggest moving the eid member there. Thanks, Ben. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
