On Fri, Apr 12, 2019 at 10:44 AM Ben Pfaff <[email protected]> wrote: > > On Fri, Apr 12, 2019 at 10:13:23AM -0700, Han Zhou wrote: > > On Fri, Apr 12, 2019 at 9:52 AM Ben Pfaff <[email protected]> wrote: > > > > > > Thanks for the series. I'd like to commit it. > > > > > > The problems with the resources needed by the tests are still there. > > > When I run with TESTSUITEFLAGS=-j10 and I have swap enabled on my > > > system, the system loses interactive response for a couple of minutes as > > > it thrashes. When I run with TESTSUITEFLAGS=-j10 and I don't have swap > > > enabled on my system, the OOM killer takes out Firefox. (I have 32 GB > > > RAM.) When I run with -j1 (the default), the testsuite takes much > > > longer. > > > > > > Here is an idea: we can put the raft tests in a new testsuite. We > > > already have a number of them. It could be invoked as "make > > > check-raft", for example. Then this testsuite could be run with lower > > > parallelism since the individual tests are so resource heavy. > > > > > > What do you think? > > > > > Hi Ben, I didn't know it was *that* slow on your laptop. It looks ok on > > mine even it is just a VM (with 4 virtual cores, 8GB mem) on my laptop, > > system responsing very well. However I agree that if you encounters such > > slowness, it may happen to others, too. I will be happy to make the change > > as you suggested. Could you point out the already existed heavy test cases > > that are in separate testsuite? I want to make sure I refer to the right > > examples before making the change. Thanks a lot! > > I am puzzled why we see such different results, but I don't think that > my system is anything unusual, so I do think that others will see > behavior similar to what I see. > > I think that it would make sense to put everything in ovsdb-cluster.at > in the new "check-raft" ("check-cluster"? whichever you prefer). I > think those are the only tests that cause trouble for me.
Hi Ben, I put ovsdb-cluster.at into "check-ovsdb-cluster" in v2: https://patchwork.ozlabs.org/patch/1084987/ There is a small problem that I couldn't figure out so I had to circumvent it this way: +# XXX: below dummy test is to invoke AT_SETUP before including any tests. +# Without this, there will be error: possibly undefined macro: AT_capture_files +# when parsing .at files that use OVS_START_SHELL_HELPERS. +AT_SETUP([dummy]) +AT_CHECK([:]) +AT_CLEANUP I spent some time but still couldn't find a better way. It is not a real problem but if you have better idea please suggest. Thank you very much. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
