On 4/26/19 1:47 AM, Numan Siddique wrote:
On Fri, Apr 26, 2019 at 11:14 AM Numan Siddique <nusid...@redhat.com
<mailto:nusid...@redhat.com>> wrote:
On Fri, Apr 26, 2019 at 1:56 AM Ben Pfaff <b...@ovn.org
<mailto:b...@ovn.org>> wrote:
On Thu, Apr 25, 2019 at 12:51:29PM -0700, Ben Pfaff wrote:
> On Thu, Apr 25, 2019 at 08:38:06AM -0400, Mark Michelson wrote:
> > Yesterday, I once again performed the task of splitting OVN
from OVS (I've
> > gotten pretty good at it now). This time, rather than
living in a personal
> > repo, you can find the ovn repo at
https://github.com/ovn-org/ovn.git
>
> I noticed that most or all of your commits lack sign-offs. Oops?
By the way, I guess that you should be the main person pushing
to this
repo for now, so I'll review some patches but I'll plan to
mostly ack
them rather than applying them to the new repo.
Thanks Mark for all the work.
Shall we consider that all the OVN patches will now be applied to
the new repo ?
If so, then all the present OVN patches under review should be
resubmitted ?
Thanks
Numan
I found an issue when compiling if I configure like below
$mkdir _gcc
$ cd _gcc
$.../configure --enable-Werror
$make -C _gcc -j5
...
libtool: link: gcc -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wformat -Wformat-security -Wswitch-enum
-Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes
-Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers
-fno-strict-aliasing -Wswitch-bool -Wlogical-not-parentheses
-Wsizeof-array-argument -Wbool-compare -Wshift-negative-value
-Wduplicated-cond -Wshadow -Wmultistatement-macros -Wcast-align=strict
-Werror -Werror -g -O2 -o vswitchd/ovs-vswitchd vswitchd/bridge.o
vswitchd/ovs-vswitchd.o vswitchd/system-stats.o vswitchd/xenserver.o
ofproto/.libs/libofproto.a
/home/nusiddiq/workspace_cpp/ovn-org/ovn/_gcc/ovs/lib/.libs/libsflow.a
lib/.libs/libsflow.a lib/.libs/libopenvswitch.a -lssl -lcrypto -lcap-ng
-latomic -lpthread -lrt -lm -lunbound
touch -c manpage-check
make[4]: Leaving directory
'/home/nusiddiq/workspace_cpp/ovn-org/ovn/_gcc/ovs'
make[3]: Leaving directory
'/home/nusiddiq/workspace_cpp/ovn-org/ovn/_gcc/ovs'
make[2]: Leaving directory
'/home/nusiddiq/workspace_cpp/ovn-org/ovn/_gcc/ovs'
make[2]: Entering directory '/home/nusiddiq/workspace_cpp/ovn-org/ovn/_gcc'
make[2]: *** No rule to make target '../ovs/ovsdb/libovsdb.la
<http://libovsdb.la>', needed by 'utilities/ovn-nbctl'. Stop.
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/nusiddiq/workspace_cpp/ovn-org/ovn/_gcc'
make[1]: *** [Makefile:3346: all-recursive] Error 1
make[1]: Leaving directory '/home/nusiddiq/workspace_cpp/ovn-org/ovn/_gcc'
make: *** [Makefile:2216: all] Error 2
make: Leaving directory '/home/nusiddiq/workspace_cpp/ovn-org/ovn/_gcc'
...
We need to fix this.
Thanks
Numan
I tried this and actually got a slightly different build error:
/bin/sh ./libtool --tag=CC --mode=link gcc -Wstrict-prototypes -Wall
-Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
-Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wswitch-bool
-Wlogical-not-parentheses -Wsizeof-array-argument -Wbool-compare
-Wshift-negative-value -Wduplicated-cond -Wshadow -g -O2 -o
utilities/ovn-nbctl utilities/ovn-nbctl.o lib/libovn.la
../ovs/ovsdb/libovsdb.la ../ovs/lib/libopenvswitch.la -lpthread -lrt -lm
-lunbound
libtool: error: cannot find the library '../ovs/ovsdb/libovsdb.la' or
unhandled argument '../ovs/ovsdb/libovsdb.la'
In both cases though, it appears the issue is that it is trying to
either build or find ovs libraries from the top-level source directory,
but they have been built in the _gcc subdirectory. I'm looking into this
to try to fix it.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
