Hi,
Initial tests show that offload is broken as netdev_rte_offloads_flow_put() is
not called.
It is not called because it is not registered.
When starting debugging it I noticed in function
netdev_register_flow_api_provider()
that we may return an uninitialized error value.
Because of this in my tests calling netdev_register_flow_api_provider()
returned with errors.
Looking at this function:
Int netdev_register_flow_api_provider(const struct netdev_flow_api
*new_flow_api)
OVS_EXCLUDED(netdev_flow_api_provider_mutex)
{
int error; // <==== should be initialized to 0
...
return error;
}
When initializing error to 0 this function returned successfully but
netdev_rte_offloads_flow_put() is
still not called.
It requires further debugging.
Regards,
Ophir
> -----Original Message-----
> From: Ophir Munk
> Sent: Tuesday, April 30, 2019 6:02 PM
> To: Ilya Maximets <[email protected]>; [email protected]
> Cc: Ian Stokes <[email protected]>; Flavio Leitner <[email protected]>;
> Kevin Traynor <[email protected]>; Roni Bar Yanai
> <[email protected]>; Finn Christensen <[email protected]>; Ben Pfaff
> <[email protected]>; Roi Dayan <[email protected]>; Simon Horman
> <[email protected]>; Olga Shern <[email protected]>;
> Asaf Penso <[email protected]>; Oz Shlomo <[email protected]>;
> Majd Dibbiny <[email protected]>
> Subject: RE: [PATCH] netdev: Dynamic per-port Flow API.
>
> > >
> > > 1. This patch changes code related to OVS offload implementation.
> > > OVS
> > offload must be confirmed with this patch before it is accepted.
> >
> > Sure. And I'll appreciate any help with testing as I'm limited with
> > offloading capable hardware.
> >
>
> Hopefully I will have test results of this patch regarding MARK+RSS offloads
> next week.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
