On 13.05.2019 15:33, Ophir Munk wrote: > Hi, > >> -----Original Message----- >> From: Ilya Maximets <[email protected]> >> Sent: Monday, May 13, 2019 12:22 PM >> To: Ophir Munk <[email protected]>; [email protected] >> Cc: Ian Stokes <[email protected]>; Flavio Leitner <[email protected]>; >> Kevin Traynor <[email protected]>; Roni Bar Yanai >> <[email protected]>; Finn Christensen <[email protected]>; Ben Pfaff >> <[email protected]>; Simon Horman <[email protected]>; Olga >> Shern <[email protected]>; Asaf Penso <[email protected]>; Oz >> Shlomo <[email protected]> >> Subject: Re: [PATCH] netdev: Dynamic per-port Flow API. >> >>> I am recreating this scenario in my setup. >> >> I see. Yes, you're right. And I think that this case could be reproduced on >> current master without any patches. So, it's a bug that we need to fix. >> Otherwise userspace datapath will try to offload its flows to the unrelated >> system interfaces. For now we could just forbid offloading to vports in dpif- >> netdev. I'll prepare the patch. This fix also should be backported. >> > > Till now there was no vport dpif-netdev offload. I think the bug you mention > was minor (getting a redundant log message like "vxlan_sys_4789 could not be > found"). > No harm was caused and vport in dpif-system behaved correctly. > Is it considered a broken implementation? Not sure. Maybe we can leave it as > is in current OVS (no backporting) and have a fix in this series for the new > vport dpif-netdev offload.
The issue will happen if "vxlan_sys_4789" will be eventually found. For example, this could happen if the kernel datapath runs at the same time and also has vxlan port. In this case dpif-netdev will try to install completely unrelated flow to the system interface. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
