On Wed, May 08, 2019 at 11:41:16AM +0300, Ilya Maximets wrote:
> > On Thu, May 02, 2019 at 05:29:16PM -0700, Darrell Ball wrote:
> >> There are a few cases where structure copy can be replaced by
> >> memcpy(), for possible portability benefit. This is because
> >> the structures involved have padding and elements of the
> >> structure are used to generate hashes.
> >>
> >> Signed-off-by: Darrell Ball <dlu998 at gmail.com>
> >
> > Thanks for the backports. I applied them to branch-2.9.
>
> Hi. These patches broke the clang build on branch-2.9 and it looks
> like not only the build:
>
> lib/conntrack.c:2563:26: error: expecting mutex 'ctb->lock' to be held at
> start
> of each loop [-Werror,-Wthread-safety-analysis]
> for (unsigned i = 0; i < CONNTRACK_BUCKETS; i++) {
Oops. I always test that master builds with clang, but I only test
backports with GCC. Maybe I should do both for backports too.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
