On Thu, Nov 14, 2019, 11:53 PM Han Zhou <[email protected]> wrote:
> On Thu, Nov 14, 2019 at 6:22 AM Dumitru Ceara <[email protected]> wrote:
> >
> > On Thu, Nov 14, 2019 at 2:14 PM Numan Siddique <[email protected]> wrote:
> > >
> > > On Thu, Nov 14, 2019 at 6:14 PM Dumitru Ceara <[email protected]>
> wrote:
> > > >
> > > > Reported-by: Numan Siddique <[email protected]>
> > > > Fixes: 32f5ebb06226 ("ovn-northd: Limit ARP/ND broadcast domain
> whenever possible.")
> > > > Signed-off-by: Dumitru Ceara <[email protected]>
> > >
> > > Thanks Dumitru for the fix. I applied this to master.
> > >
> > > Thanks
> > > Numan
> >
> > Thanks Numan and sorry for missing this case in the first place.
>
> Sorry for missing this in review. Just want to confirm, is this a bug or
> just improvement? I think it is not a bug, because the set is empty {}, it
> should just get ignored in the end by ovn-controller when translating to
> OpenFlow rules, correct?
>
This caused system tests to fail as there were warnings in the
ovn-controller log because of empty set.
Thanks
>
> > >
> > > > ---
> > > > northd/ovn-northd.c | 12 ++++++++----
> > > > 1 file changed, 8 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
> > > > index d6beb97..6742bc0 100644
> > > > --- a/northd/ovn-northd.c
> > > > +++ b/northd/ovn-northd.c
> > > > @@ -5337,10 +5337,14 @@ build_lswitch_rport_arp_req_flows(struct
> ovn_port *op,
> > > > }
> > > > }
> > > >
> > > > - build_lswitch_rport_arp_req_flow_for_ip(&all_ips_v4, AF_INET,
> sw_op,
> > > > - sw_od, 75, lflows);
> > > > - build_lswitch_rport_arp_req_flow_for_ip(&all_ips_v6, AF_INET6,
> sw_op,
> > > > - sw_od, 75, lflows);
> > > > + if (!sset_is_empty(&all_ips_v4)) {
> > > > + build_lswitch_rport_arp_req_flow_for_ip(&all_ips_v4,
> AF_INET, sw_op,
> > > > + sw_od, 75, lflows);
> > > > + }
> > > > + if (!sset_is_empty(&all_ips_v6)) {
> > > > + build_lswitch_rport_arp_req_flow_for_ip(&all_ips_v6,
> AF_INET6, sw_op,
> > > > + sw_od, 75, lflows);
> > > > + }
> > > >
> > > > sset_destroy(&all_ips_v4);
> > > > sset_destroy(&all_ips_v6);
> > > > --
> > > > 1.8.3.1
> > > >
> > > > _______________________________________________
> > > > dev mailing list
> > > > [email protected]
> > > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> > > >
> > >
> >
> > _______________________________________________
> > dev mailing list
> > [email protected]
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
