On Thu, Nov 14, 2019 at 10:56 AM Dumitru Ceara <[email protected]> wrote:
>
> On Thu, Nov 14, 2019 at 7:43 PM Numan Siddique <[email protected]> wrote:
> >
> >
> >
> > On Thu, Nov 14, 2019, 11:53 PM Han Zhou <[email protected]> wrote:
> >>
> >> On Thu, Nov 14, 2019 at 6:22 AM Dumitru Ceara <[email protected]>
wrote:
> >> >
> >> > On Thu, Nov 14, 2019 at 2:14 PM Numan Siddique <[email protected]>
wrote:
> >> > >
> >> > > On Thu, Nov 14, 2019 at 6:14 PM Dumitru Ceara <[email protected]>
wrote:
> >> > > >
> >> > > > Reported-by: Numan Siddique <[email protected]>
> >> > > > Fixes: 32f5ebb06226 ("ovn-northd: Limit ARP/ND broadcast domain
> >> whenever possible.")
> >> > > > Signed-off-by: Dumitru Ceara <[email protected]>
> >> > >
> >> > > Thanks Dumitru for the fix. I applied this to master.
> >> > >
> >> > > Thanks
> >> > > Numan
> >> >
> >> > Thanks Numan and sorry for missing this case in the first place.
> >>
> >> Sorry for missing this in review. Just want to confirm, is this a bug
or
> >> just improvement? I think it is not a bug, because the set is empty
{}, it
> >> should just get ignored in the end by ovn-controller when translating
to
> >> OpenFlow rules, correct?
> >
>
> Hi Han,
>
> As far as I see ovn-controller doesn't accept empty set. In
> parse_constant_set() we expect at least one constant:
>
> https://github.com/ovn-org/ovn/blob/master/lib/expr.c#L865
>
> So I would say that this was a bug in the ovn-northd code I added. And
> anyway it doesn't really make sense to add the flows if the address
> sets are empty.
>
> Thanks,
> Dumitru
>
Yes, you are right. I think I messed up with the empty address-set or
port-group, which works, but not empty constant set in {}.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
