On 5/13/2020 10:34 AM, Martin Varghese wrote:
On Wed, May 13, 2020 at 10:04:11AM -0700, Gregory Rose wrote:

On 5/13/2020 10:00 AM, Martin Varghese wrote:
On Wed, May 13, 2020 at 09:47:10AM -0700, Gregory Rose wrote:

On 5/12/2020 8:18 PM, Martin Varghese wrote:
On Tue, May 12, 2020 at 12:19:24PM -0700, Ben Pfaff wrote:
On Sun, May 10, 2020 at 10:40:43PM +0530, Martin Varghese wrote:
From: Martin Varghese <[email protected]>

UDP tunnel encapsulation module for tunnelling different protocols like
MPLS, IP, NSH etc

The Bareudp tunnel module provides a generic UDP L3 encapsulation
tunnelling module for tunnelling different protocols like MPLS,IP,NSH etc.
inside a UDP tunnel.

Signed-off-by: Martin Varghese <[email protected]>

What's the upstream status of the Linux datapath support?  That is, does
the bareudp code here work with the upstream Linux kernel openvswitch
module?  If it does, then it's ready for review here.  (We have an
"upstream-first" policy.)

Yes it is merged to net-next sometime back.
Please see the commits below.

4b5f672 net: Special handling for IP & MPLS.
571912c net: UDP tunnel encapsulation module for tunnelling different protocols 
like MPLS, IP, NSH etc.

Thank you for backporting these patches Martin.  We like to see a
reference to the upstream commits in the backports for the out of
tree driver.  See commit 73a6e112a539 " datapath: conntrack: mark
expected switch fall-through" for an example.


This patch has backport of the bareudp tunnel to ovs tree  + userspace changes 
to support bareudp tunnel
And the bareudp support is merged to net-next is 2 commits.I wasn't sure how to 
mention those details in this commit

It's fine to add further comments about additional changes to the
upstream commits in the backported commit messages.  The commits
here don't have to be identical to the commits upstream.


Can i add the details of both the commits to the current commit messageg with 
tag upstream commit

That will be up to the maintainers.

Thanks,

Bareudp Tunnel Support


UDP encapsulation support for tunnelling different protocols like
MPLS, IP, NSH etc

Upstream commit:

     commit 571912c69f0ed731bd1e071ade9dc7ca4aa52065
     Author: Martin Varghese <[email protected]>
     Date:   Mon Feb 24 10:57:50 2020 +0530

     net: UDP tunnel encapsulation module for tunnelling different
     protocols like MPLS, IP, NSH etc.

     The Bareudp tunnel module provides a generic L3 encapsulation
     tunnelling module for tunnelling different protocols like MPLS,
     IP,NSH etc inside a UDP tunnel.


     Signed-off-by: Martin Varghese <[email protected]>
     Acked-by: Willem de Bruijn <[email protected]>
     Signed-off-by: David S. Miller <[email protected]>

Signed-off-by: Martin Varghese <[email protected]>

The above commit msg make sense?

Yes, the format looks good to me.

Thanks,

- Greg



I have added reference of the bareudp tunnel driver commit only
I have not added the details of the commit which added special handling


- Greg




Regards,

- Greg


_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to