On 9/30/20 1:24 PM, Eelco Chaudron wrote:
>
>
> On 30 Sep 2020, at 13:19, Flavio Leitner wrote:
>
>> On Wed, Sep 30, 2020 at 08:45:07AM +0200, Eelco Chaudron wrote:
>>>
>>>
>>> On 29 Sep 2020, at 22:07, Flavio Leitner wrote:
>>>
>>>> When the number of flows in the datapath reaches twice the
>>>> maximum, revalidators will delete all flows as an emergency
>>>> action to recover. In that case, log a message with values
>>>> and increase a coverage counter.
>>>>
>>>> Signed-off-by: Flavio Leitner <[email protected]>
>>>> ---
>>>
>>> Other than the line being over 79 characters, see 0-day robot response, it
>>> looks fine to me.
>>
>> I tried to break it in different ways but none looked
>> better than what I posted to me. I am open to suggestions.
>
> Looking at it, it’s not getting better ;) I would say leave it as is!
I agree that it's hard to split this like in a good way while keeping the
indentation on this level, but that is not strictly necessary.
Following version looks fine, IMHO:
VLOG_WARN_RL(&rlem,
"Number of datapath flows (%"PRIuSIZE") twice as high as "
"current dynamic flow limit (%"PRIuSIZE"). Starting to "
"delete flows unconditionally as an emergency measure.",
n_dp_flows, kill_all_limit);
>
>> Thanks for reviewing it!
>> fbl
>>
>>>
>>> Acked-by: Eelco Chaudron <[email protected]>
>>>
>>
>> --
>> fbl
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
