On 12/18/20 6:31 AM, Ben Pfaff wrote:
> ovsdb_idl_db_parse_monitor_reply() clears the IDL and parses the
> received data.  There's no need to do it again afterward.
> 
> Signed-off-by: Ben Pfaff <[email protected]>
> Fixes: 1b1d2e6daa56 ("ovsdb: Introduce experimental support for clustered 
> databases.")
> ---
>  lib/ovsdb-idl.c | 3 ---
>  1 file changed, 3 deletions(-)
> 

LGTM,
Acked-by: Ilya Maximets <[email protected]>

> diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
> index efaa08a1e98f..fb638c499c51 100644
> --- a/lib/ovsdb-idl.c
> +++ b/lib/ovsdb-idl.c
> @@ -819,9 +819,6 @@ ovsdb_idl_process_response(struct ovsdb_idl *idl, struct 
> jsonrpc_msg *msg)
>          ovsdb_idl_db_parse_monitor_reply(&idl->data, msg->result,
>                                           OVSDB_IDL_MM_MONITOR);
>          idl->data.change_seqno++;
> -        ovsdb_idl_clear(idl);
> -        ovsdb_idl_db_parse_update(&idl->data, msg->result,
> -                                  OVSDB_IDL_MM_MONITOR);
>          break;
>  
>      case IDL_S_MONITORING:
> 

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to