On Fri, Dec 18, 2020 at 11:16:50PM +0100, Ilya Maximets wrote: > On 12/18/20 6:31 AM, Ben Pfaff wrote: > > Until now, "test-ovsdb idl" has printed the steps that it goes through > > to stdout. This commit also makes it log the same information. This > > makes it easier to match up the steps with the rest of the log (in > > particular with the jsonrpc logging). > > > > Signed-off-by: Ben Pfaff <[email protected]> > > --- > > tests/test-ovsdb.c | 248 +++++++++++++++++++++++---------------------- > > 1 file changed, 126 insertions(+), 122 deletions(-) > > Thanks! That looks nice. > > However, this patch seems incomplete. At least 'idl_set' function > still logs to stdout only while it could be called from the 'do_idl' > that prints to stdout and to the the log.
I missed that one. Thanks, I've fixed it now. > OTOH, some functions like 'do_idl_partial_update_map_column' and > 'do_idl_partial_update_set_column' are not covered too. Was it > intentional? I understand that 'do_idl' was a primary target here. I was only looking at do_idl() and its callee chain. The other functions you mentioned aren't doing anything very tricky and I've never had a complicated session debugging them (or any session at all that I remember). do_idl() has been a constant pain throughout refactoring the IDL, so I focused on that. > Some minor nits inline. I fixed these too. Thanks! I verified that the tests still pass and I will soon apply the series to this point to master. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
