On Tue, Feb 23, 2021 at 7:38 PM Numan Siddique <[email protected]> wrote: > > On Tue, Feb 23, 2021 at 4:10 PM Numan Siddique <[email protected]> wrote: > > > > On Fri, Feb 19, 2021 at 4:10 AM Ben Pfaff <[email protected]> wrote: > > > > > > This passed in the ovsrobot CI: > > > https://github.com/ovsrobot/ovn/actions/runs/579307688 > > > > > > I think that we have arrived at consensus to push this to ovn master > > > after branching happens tomorrow. Please, let me know if I > > > misunderstood! > > > > I think understanding is correct. I think Mark needs to create the branch. > > Hi Ben, > > I am trying to compile with ddlog configured, but the compilation is > failing for me > for some reason. Can you please help me with this ? > > I tried both on Fedora 33 and also on ubuntu. > > Below is the log > > ---- > vagrant@vagrant:~/ovs/ovn$ make > cd . && /bin/bash /home/vagrant/ovs/ovn/build-aux/missing > automake-1.16 --foreign Makefile > cd . && /bin/bash ./config.status Makefile depfiles > config.status: creating Makefile > config.status: executing depfiles commands > PYTHONPATH=/home/vagrant/ovs/ovn/ovs/python":"$PYTHONPATH > PYTHONDONTWRITEBYTECODE=yes /usr/bin/python3 > /home/vagrant/ovs/ovn/ovs/ovsdb/ovsdb-idlc.in annotate > ./ovn-sb.ovsschema ./lib/ovn-sb-idl.ann > lib/ovn-sb-idl.ovsidl.tmp && > \ > mv lib/ovn-sb-idl.ovsidl.tmp lib/ovn-sb-idl.ovsidl > PYTHONPATH=/home/vagrant/ovs/ovn/ovs/python":"$PYTHONPATH > PYTHONDONTWRITEBYTECODE=yes /usr/bin/python3 > /home/vagrant/ovs/ovn/ovs/ovsdb/ovsdb-idlc.in c-idl-source > lib/ovn-sb-idl.ovsidl > lib/ovn-sb-idl.c.tmp && mv > lib/ovn-sb-idl.c.tmp lib/ovn-sb-idl.c > PYTHONPATH=/home/vagrant/ovs/ovn/ovs/python":"$PYTHONPATH > PYTHONDONTWRITEBYTECODE=yes /usr/bin/python3 > /home/vagrant/ovs/ovn/ovs/ovsdb/ovsdb-idlc.in c-idl-header > lib/ovn-sb-idl.ovsidl > lib/ovn-sb-idl.h.tmp && mv > lib/ovn-sb-idl.h.tmp lib/ovn-sb-idl.h > PYTHONPATH=/home/vagrant/ovs/ovn/ovs/python":"$PYTHONPATH > PYTHONDONTWRITEBYTECODE=yes /usr/bin/python3 ./northd/ovsdb2ddlog2c -p > sb_ -f ovn-sb.ovsschema --output-file northd/ovn-northd-ddlog-sb.inc > $(cat ./northd/ovn-sb.dlopts) > PYTHONPATH=/home/vagrant/ovs/ovn/ovs/python":"$PYTHONPATH > PYTHONDONTWRITEBYTECODE=yes /usr/bin/python3 ./northd/ovsdb2ddlog2c -p > nb_ -f ovn-nb.ovsschema --output-file northd/ovn-northd-ddlog-nb.inc > $(cat ./northd/ovn-nb.dlopts) > ddlog -i northd/ovn_northd.dl -o ./northd -L > /home/vagrant/.local/ddlog/lib -L ./northd > > error: module 'OVN_Northbound' imported by northd/ovn_northd.dl not > found. Paths searched: > /home/vagrant/ovs/ovn/northd/OVN_Northbound.dl > /home/vagrant/.local/ddlog/lib/OVN_Northbound.dl > ----- > > For some reason the below target define in northd/automake.mk is not > getting invoked > ---- > northd/OVN_Northbound.dl: ovn-nb.ovsschema northd/ovn-nb.dlopts > $(AM_V_GEN)ovsdb2ddlog -f $< --output-file $@ $(nb_opts) > ---- >
I worked around the problem by manually running -- nb_opts=$(cat northd/ovn-nb.dlopts) ovsdb2ddlog -f ovn-nb.ovsschema --output-file northd/OVN_Northbound.dl $nb_opts sb_opts=$(cat northd/ovn-sb.dlopts) ovsdb2ddlog -f ovn-sb.ovsschema --output-file northd/OVN_Soutbound.dl $sb_opts --- Thanks Numan > FYI - The branch-21.03 is now created and I think we can accept these patches. > > Thanks > Numan > > > > > Thanks > > Numan > > > > > _______________________________________________ > > > dev mailing list > > > [email protected] > > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
