On Thu, Feb 25, 2021 at 12:35 PM Ben Pfaff <[email protected]> wrote: > > On Wed, Feb 24, 2021 at 12:40:17AM +0530, Numan Siddique wrote: > > On Tue, Feb 23, 2021 at 11:16 PM Ben Pfaff <[email protected]> wrote: > > > > > > On Tue, Feb 23, 2021 at 07:38:12PM +0530, Numan Siddique wrote: > > > > On Tue, Feb 23, 2021 at 4:10 PM Numan Siddique <[email protected]> wrote: > > > > > > > > > > On Fri, Feb 19, 2021 at 4:10 AM Ben Pfaff <[email protected]> wrote: > > > > > > > > > > > > This passed in the ovsrobot CI: > > > > > > https://github.com/ovsrobot/ovn/actions/runs/579307688 > > > > > > > > > > > > I think that we have arrived at consensus to push this to ovn master > > > > > > after branching happens tomorrow. Please, let me know if I > > > > > > misunderstood! > > > > > > > > > > I think understanding is correct. I think Mark needs to create the > > > > > branch. > > > > > > > > Hi Ben, > > > > > > > > I am trying to compile with ddlog configured, but the compilation is > > > > failing for me > > > > for some reason. Can you please help me with this ? > > > > > > Oops. I made a dumb typo. It didn't show up in my testing because I > > > guess a -j12 build typically built OVN_Northbound.dl and > > > OVN_Southbound.dl early enough. Here's the fix: > > > > > > diff --git a/northd/automake.mk b/northd/automake.mk > > > index 17c394c82082..d64d1d197c77 100644 > > > --- a/northd/automake.mk > > > +++ b/northd/automake.mk > > > @@ -29,7 +29,7 @@ ddlog_sources = \ > > > northd/ovn.dl \ > > > northd/ovn.rs \ > > > northd/helpers.dl > > > -ddlog_nodist_source = \ > > > +ddlog_nodist_sources = \ > > > northd/OVN_Northbound.dl \ > > > northd/OVN_Southbound.dl > > > > Thank you. It works. > > > > For the whole series > > Acked-by: Numan Siddique <[email protected]> > > > > Unfortunately because of a couple of recent commits [1], you have to > > rebase the code and you may have to add some more code in northd-ddlog to > > sync up with c northd. > > Thanks so much. I rebased, added the missing features, tested, fixed my > bugs, and applied this series to OVN master.
Thanks to you, Leonid and Justin for adding the ddlog support. Numan > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
