Hi Kevin,
> -----Original Message----- > From: Kevin Traynor <[email protected]> > Sent: Friday, July 2, 2021 4:55 AM > To: [email protected] > Cc: [email protected]; Pai G, Sunil <[email protected]>; > [email protected]; Kevin Traynor <[email protected]> > Subject: [PATCH v2 2/7] dpif-netdev: Make PMD auto load balance use > common rxq scheduling. > > PMD auto load balance had its own separate implementation of the rxq > scheduling that it used for dry runs. This was done because previously the > rxq scheduling was not reusable for a dry run. > > Apart from the code duplication (which is a good enough reason to replace it > alone) this meant that if any further rxq scheduling changes or assignment > types were added they would also have to be duplicated in the auto load > balance code too. > > This patch replaces the current PMD auto load balance rxq scheduling code to > reuse the common rxq scheduling code. > > The behaviour does not change from a user perspective, except the logs are > updated to be more consistent. > > As the dry run will compare the pmd load variances for current and estimated > assignments, new functions are added to populate the current assignments > and calculate variance on the rxq scheduling data structs. > > Now that the new rxq scheduling data structures are being used in PMD auto > load balance, the older rr_* data structs and associated functions can be > removed. > > Signed-off-by: Kevin Traynor <[email protected]> > --- > lib/dpif-netdev.c | 507 +++++++++++++++------------------------------- > 1 file changed, 160 insertions(+), 347 deletions(-) > Looks good to me. I'll ack once the github actions tests are green. Thanks and regards, Sunil _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
