Hi Kevin ,
> -----Original Message----- > From: Kevin Traynor <[email protected]> > Sent: Friday, July 2, 2021 4:55 AM > To: [email protected] > Cc: [email protected]; Pai G, Sunil <[email protected]>; > [email protected]; Kevin Traynor <[email protected]> > Subject: [PATCH v2 6/7] dpif-netdev: Allow pin rxq and non-isolate PMD. <snipped> > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 5ded7af5a..2bbbc09f8 > 100644 > --- a/lib/dpif-netdev.c > +++ b/lib/dpif-netdev.c > @@ -378,4 +378,5 @@ struct dp_netdev { > /* Rxq to pmd assignment type. */ > enum sched_assignment_type pmd_rxq_assign_type; > + bool pmd_iso; > > /* Protects the access of the 'struct dp_netdev_pmd_thread' > @@ -4404,4 +4405,22 @@ dpif_netdev_set_config(struct dpif *dpif, const > struct smap *other_config) > } > > + bool pmd_iso = smap_get_bool(other_config, "pmd-rxq-isolate", > + true); > + > + if (pmd_rxq_assign_type != SCHED_GROUP && pmd_iso == false) { > + /* Invalid combination*/ Nit: full stop missing. > + VLOG_WARN("pmd-rxq-isolate can only be set false " > + "when using pmd-rxq-assign=group"); > + pmd_iso = true; > + } > + if (dp->pmd_iso != pmd_iso) { > + dp->pmd_iso = pmd_iso; > + if (pmd_iso) { > + VLOG_INFO("pmd-rxq-affinity isolates PMD core"); > + } else { > + VLOG_INFO("pmd-rxq-affinity does not isolate PMD core"); > + } > + dp_netdev_request_reconfigure(dp); > + } > + <snipped> Rest LGTM. Thanks and regards, Sunil _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
