Hi David, On Tue, Jul 13, 2021 at 11:23:41AM +0200, David Marchand wrote: > Hello Simon, Yong, > > On Wed, Jun 9, 2021 at 11:52 AM Simon Horman <[email protected]> > wrote: > > + > > +static void > > +nl_msg_put_act_police(struct ofpbuf *request, struct tc_police police, > > + uint32_t kpkts_rate, uint32_t kpkts_burst) > > +{ > > + size_t offset, act_offset; > > + uint32_t prio = 0; > > + /* used for PPS, set rate as 0 to act as a single action */ > > + struct tc_police null_police = {0}; > > Noticed a build error with clang on Ubuntu 16.04 on ARM (in Travis): > > libtool: compile: clang -DHAVE_CONFIG_H -I. -I ./include -I ./include > -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare > -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum > -Wunused-parameter -Wbad-function-cast -Wcast-align > -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes > -Wmissing-field-initializers -Wthread-safety -fno-strict-aliasing > -Wswitch-bool -Wlogical-not-parentheses -Wsizeof-array-argument > -Wshift-negative-value -Qunused-arguments -Wshadow > -Warray-bounds-pointer-arithmetic -Werror -Werror -g -O2 > -Wno-error=unused-command-line-argument -DHAVE_AVX512F -MT > lib/netlink-conntrack.lo -MD -MP -MF lib/.deps/netlink-conntrack.Tpo > -c lib/netlink-conntrack.c -o lib/netlink-conntrack.o > lib/netdev-linux.c:2638:38: error: missing field 'action' initializer > [-Werror,-Wmissing-field-initializers] > struct tc_police null_police = {0}; > ^ > 1 error generated. > make[2]: *** [lib/netdev-linux.lo] Error 1 > make[2]: *** Waiting for unfinished jobs.... > > > The rest of the file uses memset() for this kind of init to 0. > Probably worth aligning null_police too.
Thanks for bringing this to our attention. We have posted a proposed fix for this: - [ovs-dev] [PATCH] netdev-linux: fix compile error in nl_msg_put_act_police https://www.mail-archive.com/[email protected]/msg57499.html Would it be possible for you to verify this? Travis changed a bit and I'm no longer sure how it operates. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
