Hi Kevin, 

> >
> > I wonder if the logs in the above function be INFO instead of DBG ?
> > Don't have a strong preference TBH. But if they were info, we need not
> remove any test cases no ?
> >
> 
> The reason they are debug is so they won't pollute the logs when a rebalance
> cannot occur

Yup, agree, was just thinking if there is a way to not remove any testcases :)
 
> 
> For example, if user sets ALB enabled and there is only one PMD. If it is at 
> 100%
> loaded, this message would be printed every minute to say that a ALB will do
> nothing.
> 
> As nothing is changing and it can occur every minute I thought it was more
> appropriate to keep it at debug level for when you need to check/debug the
> operation of ALB. WDYT?

Agreed :) 
Thanks!

Acked-by: Sunil Pai G <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to