On 18/10/2021 17:25, Pai G, Sunil wrote:
Hi Kevin,
I wonder if the logs in the above function be INFO instead of DBG ?
Don't have a strong preference TBH. But if they were info, we need not
remove any test cases no ?
The reason they are debug is so they won't pollute the logs when a rebalance
cannot occur
Yup, agree, was just thinking if there is a way to not remove any testcases :)
At the moment, no, but it's more to do with not having cycle
measurements and it is something to look into in general. info or debug
won't impact this as debug could be enabled during the test if required.
For example, if user sets ALB enabled and there is only one PMD. If it is at
100%
loaded, this message would be printed every minute to say that a ALB will do
nothing.
As nothing is changing and it can occur every minute I thought it was more
appropriate to keep it at debug level for when you need to check/debug the
operation of ALB. WDYT?
Agreed :)
Thanks!
Acked-by: Sunil Pai G <[email protected]>
Thanks for reviewing.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
