Hello Kumar, Thanks for looking at this series.
On Wed, Dec 1, 2021 at 1:34 PM Amber, Kumar <[email protected]> wrote: > > diff --git a/tests/dpif-netdev.at b/tests/dpif-netdev.at index > > 53eee185ad..fbb8fe9a71 100644 > > --- a/tests/dpif-netdev.at > > +++ b/tests/dpif-netdev.at > > @@ -635,3 +635,170 @@ OVS_WAIT_UNTIL([grep "flow: in_port is not an > > exact match" ovs-vswitchd.log]) > > OVS_VSWITCHD_STOP(["/flow: in_port is not an exact match/d /failed to > > put/d"]) AT_CLEANUP > > + > > +AT_SETUP([dpif-netdev - MFEX Autovalidator]) AT_SKIP_IF([! $PYTHON3 -c > > +"import scapy"], [], []) OVS_VSWITCHD_START( > > + [add-port br0 p1 \ > > + -- set interface p1 type=dummy-pmd]) > > + > > +AT_SKIP_IF([! ovs-appctl dpif-netdev/miniflow-parser-get | sed 1,4d | > > +grep "True"], [], [dnl > > +]) > > Recently we identified a scenario where the MFEX AutoValidation would not > operate as expected. > The root cause of the issue is that the AVX512 DPIF must be active for the > MFEX AutoValidator to be executed. Do you mean that there is an existing issue with the test before my changes? If so, please post a fix either against current master, or on top of my series. > > If the AVX512 DPIF is not active, the MFEX AutoValidator unit tests currently > pass, but do not actually execute. The following patch ensures that > the AVX512 DPIF is used in the unit test. If the DPIF-AVX512 is not > available, the unit test is skipped, as the scalar DPIF does not use the MFEX > function-pointer based optimizations due to community performance concerns > (https://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/) I don't get the relation with this patch. Besides, this patch is marked superseded and I don't think it made it to master yet. > > Please the following here : > > AT_SKIP_IF([! ovs-appctl dpif-netdev/dpif-impl-set dpif_avx512], [], [dnl > DPIF implementation set to dpif_avx512. > ]) > > > + > > +on_exit "pkill -f -x -9 '$PYTHON3 $srcdir/genpkts.py -1'" > > +($PYTHON3 $srcdir/genpkts.py -1 | while read pkt; do > > + ovs-appctl netdev-dummy/receive p1 "$pkt" || break > > + done) & > > + > > +AT_CHECK([ovs-appctl dpif-netdev/miniflow-parser-set autovalidator], > > +[0], [dnl Miniflow extract implementation set to autovalidator. > > +]) > > + > > +OVS_WAIT_UNTIL([test `ovs-vsctl get interface p1 statistics:rx_packets` > > +-ge 1000]) pkill -f -x -9 '$PYTHON3 $srcdir/genpkts.py -1' > > + > > +OVS_VSWITCHD_STOP > > +AT_CLEANUP > > + -- David Marchand _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
