Hi David, Please find the Replies inline.
> -----Original Message----- > From: David Marchand <[email protected]> > Sent: Wednesday, December 1, 2021 6:24 PM > To: Amber, Kumar <[email protected]> > Cc: [email protected]; [email protected]; Stokes, Ian > <[email protected]>; [email protected]; [email protected]; > [email protected]; [email protected] > Subject: Re: [PATCH v3 4/4] tests: Move MFEX tests to dpif-netdev. > > Hello Kumar, > > Thanks for looking at this series. > > On Wed, Dec 1, 2021 at 1:34 PM Amber, Kumar <[email protected]> > wrote: > > > diff --git a/tests/dpif-netdev.at b/tests/dpif-netdev.at index > > > 53eee185ad..fbb8fe9a71 100644 > > > --- a/tests/dpif-netdev.at > > > +++ b/tests/dpif-netdev.at > > > @@ -635,3 +635,170 @@ OVS_WAIT_UNTIL([grep "flow: in_port is not an > > > exact match" ovs-vswitchd.log]) > > > OVS_VSWITCHD_STOP(["/flow: in_port is not an exact match/d /failed > > > to > > > put/d"]) AT_CLEANUP > > > + > > > +AT_SETUP([dpif-netdev - MFEX Autovalidator]) AT_SKIP_IF([! $PYTHON3 > > > +-c "import scapy"], [], []) OVS_VSWITCHD_START( > > > + [add-port br0 p1 \ > > > + -- set interface p1 type=dummy-pmd]) > > > + > > > +AT_SKIP_IF([! ovs-appctl dpif-netdev/miniflow-parser-get | sed 1,4d > > > +| grep "True"], [], [dnl > > > +]) > > > > Recently we identified a scenario where the MFEX AutoValidation would not > operate as expected. > > The root cause of the issue is that the AVX512 DPIF must be active for the > MFEX AutoValidator to be executed. > > Do you mean that there is an existing issue with the test before my changes? > If so, please post a fix either against current master, or on top of my > series. > Yes, makes perfect sense would post a patch over this patch-set to fix the issue mentioned above. Otherwise Looks good to me. Acked-by: Kumar Amber <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
