On 11/10/21 11:07, Sunil Pai G wrote:
> Currently the configure script provides no infomation but to update
> the pkg-config path on failure to link with DPDK.
> Fix this to provide more information to the user on failure.
> 
> Before:
> checking whether linking with dpdk works... no
> configure: error: Could not find DPDK library in default search path,
> update PKG_CONFIG_PATH for pkg-config to find the .pc file in
> non-standard location
> 
> After:
> checking whether linking with dpdk works... no
> configure: error: configure:27158: gcc -o conftest -include rte_config.h ...
> -Wl,--whole-archive -l:librte_bus_pci.a -l:my_lib.a ... -lunwind >&5
> /usr/bin/ld: cannot find -l:my_lib.a

Hi, Sunil.

I don't think that printing parts of a config.log is a good thing
to do.  Primarily because if ./configure failed, users need to
look at config.log anyway.  That's a normal thing for all automake
based build systems.

One thing that we can improve is the error message.  Currently it
assumes that the path is not correct, but it should not exclude
the scenario where path is correct, but the library is broken, i.e.
has missing dependencies.

Maybe addition of a single "working" word to the message will be
enough:

"Could not find working DPDK library in default search path, ..."

Or something similar.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to