On 8 Dec 2021, at 8:59, Sunil Pai G wrote:
> Currently, on failure to link with DPDK, the configure script provides
> an error message to update the PKG_CONFIG_PATH even though the cause of
> failure was missing dependencies. Improve the error message to include this
> scenario.
>
> Signed-off-by: Sunil Pai G <[email protected]>
> ---
> v2-> v3: Fix sentence.
> v1-> v2: Improve logging instead of printing contents from config.log
> ---
> acinclude.m4 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/acinclude.m4 b/acinclude.m4
> index dba365ea1..15391e68d 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -486,7 +486,8 @@ AC_DEFUN([OVS_CHECK_DPDK], [
> DPDKLIB_FOUND=true],
> [AC_MSG_RESULT([no])
> AC_MSG_ERROR(m4_normalize([
> - Could not find DPDK library in default search path, update
> + Failed to link with DPDK, check config.log for more details.
> + Could not find working DPDK library in default search path, update
> PKG_CONFIG_PATH for pkg-config to find the .pc file in
> non-standard location]))
What about making the whole text more fluent (not a native speaker, so maybe it
can be done better :)
Failed to link with DPDK, check the config.log for more details.
If a working DPDK library was not found in the default search
path, update PKG_CONFIG_PATH for pkg-config to find the .pc
file in a non-standard location.
> ])
> --
> 2.25.1
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
