On Thu, Dec 9, 2021 at 1:27 PM Ian Stokes <[email protected]> wrote:
>
> This commit adds support for DPDK v21.11, it includes the following
> changes.
>
> 1. ci: Install python elftools for DPDK 21.02.
> 2. ci: Update meson requirement for DPDK 21.05.
> 3. netdev-dpdk: Fix build with 21.05.
> 4. ci: Compile DPDK in non developer mode.
>
> http://patchwork.ozlabs.org/project/openvswitch/list/?series=242480&state=*
>
> 5. netdev-dpdk: Remove access to DPDK internals.
> 6. netdev-dpdk: Remove unused attribute from rte_flow rule.
> 7. netdev-dpdk: Fix mbuf macros namespace with 21.11-rc1.
> 8. netdev-dpdk: Fix vhost namespace with 21.11-rc2.
>
> http://patchwork.ozlabs.org/project/openvswitch/list/?series=271040&state=*
>
> In addition documentaion and DPDK unit tests were also updated in this
> commit for use with DPDK v21.11.
>
> For credit all authors of the original commits to 'dpdk-latest' with the above
> changes have been added as co-authors for this commit.
>
> Signed-off-by: David Marchand <[email protected]>
> Co-authored-by: David Marchand <[email protected]>
> Reviewed-by: Maxime Coquelin <[email protected]>
> Signed-off-by: Ian Stokes <[email protected]>
>
> ---
> RFC -> V1
> * Add telemetry warning to OVS DPDK unit tests.
> * Update TSO documentation link to 21.11.
> * Update fedora spec to use 21.11.
> ---
> .ci/linux-build.sh | 6 +-
> .ci/linux-prepare.sh | 4 +-
> Documentation/faq/releases.rst | 2 +-
> Documentation/intro/install/dpdk.rst | 16 +-
> Documentation/topics/dpdk/phy.rst | 8 +-
> Documentation/topics/dpdk/vdev.rst | 2 +-
> Documentation/topics/dpdk/vhost-user.rst | 2 +-
> Documentation/topics/testing.rst | 2 +-
> Documentation/topics/userspace-tso.rst | 2 +-
> NEWS | 1 +
> lib/dp-packet.h | 26 +-
> lib/netdev-dpdk.c | 115 +++----
> rhel/openvswitch-fedora.spec | 515
> +++++++++++++++++++++++++++++++
You should update rhel/openvswitch-fedora.spec.in not the generated
rhel/openvswitch-fedora.spec.
> tests/system-dpdk.at | 16 +-
> 14 files changed, 624 insertions(+), 93 deletions(-)
> create mode 100644 rhel/openvswitch-fedora.spec
>
[snip]
> diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at
> index e0e750fde..d0f6ee394 100644
> --- a/tests/system-dpdk.at
> +++ b/tests/system-dpdk.at
> @@ -15,7 +15,8 @@ AT_CHECK([grep "DPDK Enabled - initialized"
> ovs-vswitchd.log], [], [stdout])
> OVS_VSWITCHD_STOP(["/Global register is changed during/d
> /EAL: Invalid NUMA socket, default to 0/d
> /EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using unreliable
> clock cycles !/d
> -/EAL: No free hugepages reported in hugepages-1048576kB/d"])
> +/EAL: No free hugepages reported in hugepages-1048576kB/d
> +/TELEMETRY: No legacy callbacks, legacy socket not created/d"])
> AT_CLEANUP
> dnl
> --------------------------------------------------------------------------
>
> @@ -37,12 +38,12 @@ sleep 2
>
> dnl Clean up
> AT_CHECK([ovs-vsctl del-port br10 phy0], [], [stdout], [stderr])
> -OVS_VSWITCHD_STOP("/does not exist. The Open vSwitch kernel module is
> probably not loaded./d
> +OVS_VSWITCHD_STOP(["/does not exist. The Open vSwitch kernel module is
> probably not loaded./d
> /Failed to enable flow control/d
> /Global register is changed during/d
> /EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using unreliable
> clock cycles !/d
> /EAL: No free hugepages reported in hugepages-1048576kB/d
> -")
> +/TELEMETRY: No legacy callbacks, legacy socket not created/d"])
This log is displayed when DPDK is compiled without libjansson (in
this case, the metrics library register no "legacy" callbacks, hence
the log..).
Ok for waiving it for now.
I'll submit a patch on DPDK side to lower it to INFO level because I
find it useless.
Rest lgtm.
Thanks Ian!
--
David Marchand
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
