On 12/9/21 16:24, Stokes, Ian wrote: >> On Thu, Dec 9, 2021 at 1:27 PM Ian Stokes <[email protected]> wrote: >>> >>> This commit adds support for DPDK v21.11, it includes the following >>> changes. >>> >>> 1. ci: Install python elftools for DPDK 21.02. >>> 2. ci: Update meson requirement for DPDK 21.05. >>> 3. netdev-dpdk: Fix build with 21.05. >>> 4. ci: Compile DPDK in non developer mode. >>> >>> >> http://patchwork.ozlabs.org/project/openvswitch/list/?series=242480&state=* >>> >>> 5. netdev-dpdk: Remove access to DPDK internals. >>> 6. netdev-dpdk: Remove unused attribute from rte_flow rule. >>> 7. netdev-dpdk: Fix mbuf macros namespace with 21.11-rc1. >>> 8. netdev-dpdk: Fix vhost namespace with 21.11-rc2. >>> >>> >> http://patchwork.ozlabs.org/project/openvswitch/list/?series=271040&state=* >>> >>> In addition documentaion and DPDK unit tests were also updated in this >>> commit for use with DPDK v21.11. >>> >>> For credit all authors of the original commits to 'dpdk-latest' with the >>> above >>> changes have been added as co-authors for this commit. >>> >>> Signed-off-by: David Marchand <[email protected]> >>> Co-authored-by: David Marchand <[email protected]> >>> Reviewed-by: Maxime Coquelin <[email protected]> >>> Signed-off-by: Ian Stokes <[email protected]> >>> >>> --- >>> RFC -> V1 >>> * Add telemetry warning to OVS DPDK unit tests. >>> * Update TSO documentation link to 21.11. >>> * Update fedora spec to use 21.11. >>> --- >>> .ci/linux-build.sh | 6 +- >>> .ci/linux-prepare.sh | 4 +- >>> Documentation/faq/releases.rst | 2 +- >>> Documentation/intro/install/dpdk.rst | 16 +- >>> Documentation/topics/dpdk/phy.rst | 8 +- >>> Documentation/topics/dpdk/vdev.rst | 2 +- >>> Documentation/topics/dpdk/vhost-user.rst | 2 +- >>> Documentation/topics/testing.rst | 2 +- >>> Documentation/topics/userspace-tso.rst | 2 +- >>> NEWS | 1 + >>> lib/dp-packet.h | 26 +- >>> lib/netdev-dpdk.c | 115 +++---- >>> rhel/openvswitch-fedora.spec | 515 >> +++++++++++++++++++++++++++++++ >> >> You should update rhel/openvswitch-fedora.spec.in not the generated >> rhel/openvswitch-fedora.spec. > > Ah, apologies, I've spun a v2 and corrected this + rebased on master. > > [snip] > >> This log is displayed when DPDK is compiled without libjansson (in >> this case, the metrics library register no "legacy" callbacks, hence >> the log..). >> Ok for waiving it for now. >> I'll submit a patch on DPDK side to lower it to INFO level because I >> find it useless. >> >> >> Rest lgtm. >> >> Thanks Ian! > > Thanks David, as I said, I've sent a v2. > > @Ilya Maximets Are there any blockers you see or am I good to merge this?
On a brief look-through I didn't notice anything blocking in v2. Though, I didn't try to use it. So, if David and Kevin are OK with the patch, then it should be good to go. Best regards, Ilya Maximets. > > Thanks > Ian >> >> >> -- >> David Marchand > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
