> On 09/12/2021 15:21, Ian Stokes wrote:
> > This commit adds support for DPDK v21.11, it includes the following
> > changes.
> >
> > 1. ci: Install python elftools for DPDK 21.02.
> > 2. ci: Update meson requirement for DPDK 21.05.
> > 3. netdev-dpdk: Fix build with 21.05.
> > 4. ci: Compile DPDK in non developer mode.
> >
> >
> http://patchwork.ozlabs.org/project/openvswitch/list/?series=242480&state=*
> >
> > 5. netdev-dpdk: Remove access to DPDK internals.
> > 6. netdev-dpdk: Remove unused attribute from rte_flow rule.
> > 7. netdev-dpdk: Fix mbuf macros namespace with 21.11-rc1.
> > 8. netdev-dpdk: Fix vhost namespace with 21.11-rc2.
> >
> >
> http://patchwork.ozlabs.org/project/openvswitch/list/?series=271040&state=*
> >
> 
> There was a v3, so it should be:
> http://patchwork.ozlabs.org/project/openvswitch/list/?series=271159&state=*
> 
> > In addition documentaion and DPDK unit tests were also updated in this
> > commit for use with DPDK v21.11.
> >
> 
> typo, documentation
> 
> > For credit all authors of the original commits to 'dpdk-latest' with the 
> > above
> > changes have been added as co-authors for this commit.
> >
> > Signed-off-by: David Marchand<[email protected]>
> > Co-authored-by: David Marchand<[email protected]>
> > Reviewed-by: Maxime Coquelin<[email protected]>
> > Signed-off-by: Ian Stokes<[email protected]>
> >
> 
> There's no tested-by or mention of testing above. I didn't see it in the
> email threads either. Maybe that can be mentioned in the commit message
> to confirm it was done.
> 
> > ---
> 
> Just a few nits in the commit message that can be fixed on applying.
> 
> Otherwise assuming it went through Intel OVS ci, the patches lgtm
> (though i didn't review the ethdev internals one in detail). Built and
> ran a basic test to move some pkts, no issue.
> 
> btw, having links to the relevant DPDK commits in the ovs commit logs is
> really helpful for cross referencing, we should keep doing that. David++.
+1

Thanks for the review Kevin, I've applied the changes and pushed to master.

Thanks all for all the work on this, much appreciated.

Thanks
Ian



_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to