On Tue, Dec 21, 2021 at 1:57 PM Han Zhou <[email protected]> wrote: > > On Tue, Dec 21, 2021 at 9:31 AM Numan Siddique <[email protected]> wrote: > > > > On Fri, Dec 17, 2021 at 4:29 PM Dumitru Ceara <[email protected]> wrote: > > > > > > Similar to the OVS series [0], this one fixes the issues reported for > > > the OVN code base. > > > > > > After [0] (or similar) is accepted in OVS a patch to add UBSanitizer > > > to OVN GitHub CI will be required. > > > > > > [0] > https://patchwork.ozlabs.org/project/openvswitch/list/?series=277375&state=* > > > > Thanks for addressing these errors. It'd be great to have Github CI > > with UBSanitizer. > > > > I've Acked all the patches. > > > > @Mark Michelson @Han Zhou I wonder if these can be considered for 21.12 ? > > Thanks Dumitru and Numan. I haven't reviewed all the patches yet. Could you > tell the impact of the fixes (and the consequence of not applying to 21.12)?
Perhaps Dumitru can comment better. From what I understand these fixes address the possible undefined behavior errors at runtime. The patches don't seem critical to me since much of the code (this patch series fixes) is present since many releases. I'm fine either way. Want to know Dumitru's thoughts on this. Regards Numan > > > > > Numan > > > > > > > > Dumitru Ceara (6): > > > pinctrl: Ensure proper alignment when using > pinctrl_compose_ipv*(). > > > pinctrl: Ensure no misaligned accesses for SCTP packets. > > > pinctrl: Ensure aligned accesses when processing DNS. > > > pinctrl: Ensure packet headers are properly aligned for ICMP > errors. > > > pinctrl: Avoid misaligned access to controller_event_opt_header. > > > pinctrl: Avoid misaligned access to ovs_ra_msg. > > > > > > controller/pinctrl.c | 220 > ++++++++++++++++++++------------------------------ > > > lib/actions.c | 25 +++--- > > > lib/ovn-l7.h | 6 + > > > lib/ovn-util.h | 12 ++- > > > 4 files changed, 114 insertions(+), 149 deletions(-) > > > > > > _______________________________________________ > > > dev mailing list > > > [email protected] > > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
