On 1/6/22 19:38, Mark Michelson wrote: > On 12/23/21 14:40, Dumitru Ceara wrote: >> On 12/21/21 21:22, Numan Siddique wrote: >>> On Tue, Dec 21, 2021 at 1:57 PM Han Zhou <[email protected]> wrote: >>>> >>>> On Tue, Dec 21, 2021 at 9:31 AM Numan Siddique <[email protected]> wrote: >>>>> >>>>> On Fri, Dec 17, 2021 at 4:29 PM Dumitru Ceara <[email protected]> >>>>> wrote: >>>>>> >>>>>> Similar to the OVS series [0], this one fixes the issues reported for >>>>>> the OVN code base. >>>>>> >>>>>> After [0] (or similar) is accepted in OVS a patch to add UBSanitizer >>>>>> to OVN GitHub CI will be required. >>>>>> >>>>>> [0] >>>> https://patchwork.ozlabs.org/project/openvswitch/list/?series=277375&state=* >>>> >>>>> >>>>> Thanks for addressing these errors. It'd be great to have Github CI >>>>> with UBSanitizer. >> >> Once the OVS ones are addressed I'll send a patch to enable these checks >> in OVN CI too. >> >>>>> >>>>> I've Acked all the patches. >>>>> >>>>> @Mark Michelson @Han Zhou I wonder if these can be considered for >>>>> 21.12 ? >>>> >>>> Thanks Dumitru and Numan. I haven't reviewed all the patches yet. >>>> Could you >>>> tell the impact of the fixes (and the consequence of not applying to >>>> 21.12)? >>> >>> Perhaps Dumitru can comment better. From what I understand these >>> fixes address the possible undefined behavior errors at runtime. >>> >> >> That's the case, yes. >> >>> The patches don't seem critical to me since much of the code (this >>> patch series fixes) is present since many releases. >>> >> >> I don't know of any evidence of these UB instances affecting any >> existing production deployments but it's hard to tell. It depends on >> lots of factors (arch, compiler, etc). My guess is that we're >> *probably* ok on x86. >> >>> I'm fine either way. Want to know Dumitru's thoughts on this. >>> >> >> I think it's fine to have these only on main branch for now. We can >> always reconsider things later if needed. > > Since we're past the release of 21.12, the issue of whether to put the > changes there isn't as critical now. So I pushed the changes to main and > to branch-21.12. If we make a 21.12.1, then the changes will be present > there. >
Thanks! _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
